search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
831 stars 234 forks source link

Investigate unused imports in tests/* #916

Closed richardgreg closed 4 months ago

richardgreg commented 6 months ago

What was wrong?

There are unused imports in the test folder. Refactoring needed Related to Issue # closes #901

How was it fixed?

Use pylint to find unused import and refactor it

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

SamWilsn commented 6 months ago

This is a great start; thank you so much! To prevent these from creeping back in, I've re-enabled flake8 on the test folder on this branch. It'll probably find a bunch more issues. If you can fix them, we'd really appreciate it. If not, I'll be back to clean them up when I get the chance.

richardgreg commented 6 months ago

You're welcome. I'd be happy to keep the changes coming.

richardgreg commented 4 months ago

@SamWilsn are there any more implementations needed for this pr for it to be merged?

SamWilsn commented 4 months ago

Tests passed locally!