search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
806 stars 222 forks source link

Replace ensure with if-statements #932

Closed SamWilsn closed 1 month ago

SamWilsn commented 2 months ago

What was wrong?

Related to Issue #588

How was it fixed?

https://gist.github.com/SamWilsn/f91192bf4f3988aa5150d5e5d248c2c3

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 586 lines in your changes are missing coverage. Please review.

Project coverage is 74.28%. Comparing base (f5a3b89) to head (a91977d). Report is 64 commits behind head on master.

Files Patch % Lines
src/ethereum/arrow_glacier/fork.py 0.00% 72 Missing :warning:
src/ethereum/gray_glacier/fork.py 0.00% 72 Missing :warning:
src/ethereum/dao_fork/fork.py 0.00% 64 Missing :warning:
src/ethereum/muir_glacier/fork.py 0.00% 62 Missing :warning:
src/ethereum/paris/fork.py 48.14% 28 Missing :warning:
src/ethereum/rlp.py 73.68% 15 Missing :warning:
src/ethereum/constantinople/fork.py 80.64% 12 Missing :warning:
src/ethereum/byzantium/fork.py 82.25% 11 Missing :warning:
src/ethereum/frontier/fork.py 82.25% 11 Missing :warning:
src/ethereum/homestead/fork.py 82.25% 11 Missing :warning:
... and 79 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #932 +/- ## ========================================== + Coverage 74.26% 74.28% +0.02% ========================================== Files 602 643 +41 Lines 32670 35932 +3262 ========================================== + Hits 24261 26693 +2432 - Misses 8409 9239 +830 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/932/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/932/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `74.28% <60.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.