search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
806 stars 222 forks source link

Add EIP-7623 implementation #934

Closed nerolation closed 1 week ago

nerolation commented 2 months ago

Reopened for https://github.com/ethereum/execution-specs/pull/897

SamWilsn commented 1 month ago

This is meant for Prague right? We have our Prague branch at forks/prague.

Feel free to move this over there (both changing the base branch and editing the src/ethereum/prague directory instead), or I can probably edit the pull request if you'd like.

nerolation commented 1 month ago

This is meant for Prague right? We have our Prague branch at forks/prague.

Feel free to move this over there (both changing the base branch and editing the src/ethereum/prague directory instead), or I can probably edit the pull request if you'd like.

How "set" are the changes in src/ethereum/prague? We haven't had full consensus on the inclusion of 7623 into prague so I'd probably wait until the next ACDE for confirmation.

SamWilsn commented 1 month ago

We don't need to merge the pull request until it's ready according to ACDE. I'm suggesting that you make the base branch of your pull request forks/prague instead of master.

nerolation commented 4 weeks ago

I've merged them here, @SamWilsn :

https://github.com/ethereum/execution-specs/pull/959/files

I'm not sure why the changelog includes other files/changes that I didn't touch.