`std::evm` functions should take buffer types

ethereum / fe

Emerging smart contract language for the Ethereum blockchain.

https://fe-lang.org

Other

1.61k stars 187 forks source link

`std::evm` functions should take buffer types #891

Closed g-r-a-n-t closed 9 months ago

g-r-a-n-t commented 1 year ago

What is wrong?

A number of functions defined in std::evm take offsets and lengths for regions of memory and calldata. These should take buffer types instead.

How can it be fixed

implement CalldataBuffer, CalldataBufferReader
update revert_mem, return_mem, call_data_copy, code_copy, ext_code_copy, keccak256_mem, create, create2, call, and log

run $ cargo test std_lib to check changes made to crates/library

Hrushi20 commented 10 months ago

Hey, can I work on this issue? Can you give me a brief idea about CalldataBuffer and CalldataBufferReader, so that I can start working on this issue.

g-r-a-n-t commented 9 months ago

hey sorry for the late reply @Hrushi20

this work has been completed, but I could help you find another task if you're interested

Hrushi20 commented 9 months ago

Hey! I'm interested. Any beginner friendly issues I can get started with?

g-r-a-n-t commented 9 months ago

would you be interested in adding support for the transient storage opcodes?

g-r-a-n-t commented 9 months ago

here, just wrote an issue https://github.com/ethereum/fe/issues/978