search

ethereum / fe

Emerging smart contract language for the Ethereum blockchain.
https://fe-lang.org
Other
1.61k stars 187 forks source link

std::evm functions should take buffer types #891 (Part 1) #893

Closed saifalkatout closed 1 year ago

saifalkatout commented 1 year ago

What was wrong?

A number of functions defined in std::evm take offsets and lengths for regions of memory and calldata. These should take buffer types instead.

How was it fixed?

updated revert_mem, return_mem, ext_code_copy, keccak256_mem, create, create2, call, and log

g-r-a-n-t commented 1 year ago

it looks like the tests are failing because new snaposhots have been generated. try cargo insta review

https://docs.rs/insta/latest/insta/

overall this looks great