search

ethereum / fe

Emerging smart contract language for the Ethereum blockchain.
https://fe-lang.org
Other
1.6k stars 179 forks source link

v2 parser: change assignment's lhs to expression #935

Closed saifalkatout closed 11 months ago

saifalkatout commented 11 months ago

What was wrong?

The new parser (v2 branch) wrongly supposes the assignment destination is a pattern, but it should be an expression.

How was it fixed?

Parse lhs in assignment statements as an expression.

To-Do

saifalkatout commented 11 months ago

@Y-Nak how pivotal is the removal of unnecessary commits ? I tried to revert and rebase but nothing seemed to work, I can delete my branch and push the changes again if necessary.

Y-Nak commented 11 months ago

You can squash these commits(you probably need to use git rabase -i command). (NOTE: I can squash your changes on github, but I think this would be a nice opportunity for you to get used to git.) Also, from the next time, it'd be nice to specify a base branch when you checkout to a new branch, like git checkout -b your-branch upstream/fe-v2 or something.

Y-Nak commented 11 months ago

@saifalkatout oh, you didn't need to close this. You could squash, then force push.

saifalkatout commented 11 months ago

I am sort of experimenting with it, To see how I could revert back. If you check my fork Im at 17 commits ahead 😂