ethereum / fe

Emerging smart contract language for the Ethereum blockchain.
https://fe-lang.org
Other
1.6k stars 179 forks source link

Add instruction to install Rosetta for MacOS ARM #960

Closed 0xferit closed 9 months ago

0xferit commented 10 months ago

What was wrong?

Executable does not work on MacOS ARM unless Rosetta is installed. The user guide does not mention this detail.

How was it fixed?

Added the instruction and warning about this issue to the installation guide.

0xferit commented 10 months ago

CI / lint fails for a totally irrelevant reason. Perhaps running the workflow again will make it resolve by itself.

error: unnecessarily eager cloning of iterator items --> crates/test-utils/src/lib.rs:565:9 565 / data.iter() 566 .cloned() 567 .filter( val { 568 // ethabi doesn't yet support error types so we just filter them out for now 569 // https://github.com/rust-ethereum/ethabi/issues/225 570 val["type"] != "error" 571 }) __^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `-D clippy::iter-overeager-cloned` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::iter_overeager_cloned)]`
help: try 565 ~ data.iter().filter( &val { 566 + // ethabi doesn't yet support error types so we just filter them out for now 567 + // https://github.com/rust-ethereum/ethabi/issues/225 568 + val["type"] != "error" 569 + }).cloned()

error: could not compile fe-compiler-test-utils (lib) due to previous error warning: build failed, waiting for other jobs to finish... Error: Process completed with exit code 101.

cburgdorf commented 9 months ago

This looks like a new clippy check (clippy isn'f fixed to a specific version in CI) that needs to be satisfied. Nothing that needs to be added to this PR but the PR will eventually need to be rebased when the fix lands in master.

cburgdorf commented 9 months ago

@0xferit The issue is resolved in latest master. Could you rebase the PR and force push it.

sbillig commented 9 months ago

@0xferit The issue is resolved in latest master. Could you rebase the PR and force push it.

I'm just going to merge this, no need to rebase.