ethereum / glados

Portal network monitoring application.
65 stars 30 forks source link

feat: add favicon.ico for browser icon #327

Closed carver closed 1 month ago

carver commented 1 month ago

I was annoyed by the 404s in glados-web, so I added a favicon.

While adding this, I discovered that the fallback service that serves static files from the root was being overwritten by the 404 fallback, so static files were not being served correctly from the root URL.

That 404 handler was first added to fix https://github.com/ethereum/glados/issues/64 but this seems to have been a mistake, since the fallback doesn't get invoked in the use case for the issue.

I confirmed that 404s are still returned by a missing url like: http://glados/UNSUPPORTED_PATH