miner: channel operations found blocking forever during fuzzing

[BurtonQin]

System information

Geth version: geth version OS & Version: Windows/Linux/OSX Commit hash : 56e9001a1a8ddecc478943170b00207ef46109b9

Expected behaviour

The channel sending/receiving/select operation shall not block forever whatever the order of the concurrent messages.

Actual behaviour

We found 13 blocking issues by fuzzing the code from

• Entry point 1: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/miner_test.go#L81

  1. Blocked at the receiving operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/state/snapshot/generate.go#L748 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/state/snapshot/generate.go#L166
  2. Blocked at the select operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/miner.go#L99-L100
  3. Blocked at the select operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/worker.go#L564-L565
  4. Blocked at the select operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/worker.go#L599-L600

• Entry point 2: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/unconfirmed_test.go#L59

  5. Blocked at for range channel at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_cacher.go#L62-L63 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_cacher.go#L49-L52

• Entry point 3: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/miner/worker_test.go#L270

  6. Blocked at the 4 receiving operations at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_pool.go#L1071-L1072 https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_pool.go#L1082 https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_pool.go#L1092 https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_pool.go#L1104 The channels are created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/tx_pool.go#L282-L286

• Entry point 4: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/abi/bind/backends/simulated_test.go#L160

  7. Blocked at the receiving operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/abi/bind/backends/simulated.go#L868-L873 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/event/subscription.go#L49-L50 Entry point 5: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/signer/core/signed_data_test.go#L183
  8. Blocked at the receiving operations at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/manager.go#L111-L112 https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/manager.go#L126 The channels are created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/manager.go#L60 https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/accounts/manager.go#L73

Entry point 6: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/bloombits/matcher_test.go#L68

9. Blocked at the receiving operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/bloombits/matcher.go#L561 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/bloombits/matcher.go#L555-L556
10. Blocked at the receiving operation at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/bloombits/matcher.go#L575 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/core/bloombits/matcher.go#L569-L570
    • Entry point 7: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/les/utils/limiter_test.go#L108
11. Blocked at the receiving operation https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/les/utils/limiter.go#L319-L320 The channel is created at https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/les/utils/limiter.go#L318
    • Entry point 8: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/p2p/discover/v4_udp_test.go#L163
12. Blocked at the select operation https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/p2p/discover/v4_udp.go#L396-L402
    • Entry point 9: https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/p2p/transport_test.go#L107
13. Blocked at the select operation https://github.com/ethereum/go-ethereum/blob/56e9001a1a8ddecc478943170b00207ef46109b9/p2p/message.go#L190-L193

    Steps to reproduce the behaviour

    We found the blocking issues through a WIP Fuzzing project by system-pclub, PSU.

Backtrace

[charlesxsh]

Hi there, kindly ask do we have any update on this PR?