search

ethereum / go-ethereum

Go implementation of the Ethereum protocol
https://geth.ethereum.org
GNU Lesser General Public License v3.0
47.42k stars 20.07k forks source link

Reduce log levels for certain messages #23908

Closed pyggie closed 10 months ago

pyggie commented 2 years ago

System information

Geth version: Version: 1.10.12-stable OS & Version: Linux

Expected behaviour

An ERROR message in the logs should reveal a serious problem that the user should review.

Actual behaviour

Some ERROR messages are informational at best and are distracting to a user trying to monitor serious problems. Especially this common one:

ERROR[11-14|22:56:33.439] Snapshot extension registration failed   peer=xxxx err="peer connected on snap without compatible eth support"

A similar common example for WARN:

WARN [11-14|23:01:29.317] Checkpoint challenge timed out, dropping id=xxxx conn=inbound addr=...
MariusVanDerWijden commented 2 years ago

I agree that the log levels for certain log messages are not great right now. We should put both snap without eth and checkpoint challenge to info since they come up rather often because of people forking geth for other chains

karalabe commented 2 years ago

Yes and no. They do signal that there's significant peer churn, which ENRs and the discovery protocol should have filtered out.

MariusVanDerWijden commented 10 months ago

We've reduced the log level for the messages/removed them. Closing this now. Please open a new issue if there are other log messages that annoy you