v1.12.0 tag make failed

[godeamon]

System information

Geth version: v1.12.0

OS & Version: centos gcc 4.8.5

Expected behaviour

make failed:

[godeamon]

v1.11.6 tag compile successed, maybe blst repo?

[godeamon]

build/ci.go file add this code will be success buildTags = []string{"CGO_CFLAGS", "-std=c99"} 213 line.

[holiman]

I wonder if it's worth opening this as a ticket on blst instead -- the code is here: https://github.com/supranational/blst/blob/master/bindings/go/blst.go#L44

I mean sure, we can change flags, but fixing it at the source benefits all consumers of the library.

[godeamon]

I wonder if it's worth opening this as a ticket on blst instead -- the code is here: https://github.com/supranational/blst/blob/master/bindings/go/blst.go#L44

I mean sure, we can change flags, but fixing it at the source benefits all consumers of the library.

@holiman thanks, but how should I compile geth version v1.12.0 ?

[fjl]

I also wonder why this issue did not occur in any of the build environments that we have. Maybe newer gcc versions default to C99?

[fjl]

It looks like gcc 5 does have the required features by default.

[godeamon]

I also wonder why this issue did not occur in any of the build environments that we have. Maybe newer gcc versions default to C99?

Yes, gcc 5 may not have this problem.

[godeamon]

I upgraded the gcc version to 12, now it works, thanks for the reply