search

ethereum / go-ethereum

Go implementation of the Ethereum protocol
https://geth.ethereum.org
GNU Lesser General Public License v3.0
47.28k stars 20.02k forks source link

cmd/utils: default gas price flag #30076

Closed cyberhorsey closed 3 months ago

cyberhorsey commented 3 months ago

The implementation for this default gas price exists, but is actually unable to be set via a flag, because the flag was not created. This PR simply adds the flag and the context check if its set, and updates cfg.Default if so.

MariusVanDerWijden commented 3 months ago

@cyberhorsey what do you think about this: https://github.com/ethereum/go-ethereum/pull/30080 The default wasn't really used anywhere so we can just get rid of it. It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user. Lemme know if I missed something

cyberhorsey commented 3 months ago

@cyberhorsey what do you think about this: #30080 The default wasn't really used anywhere so we can just get rid of it. It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user. Lemme know if I missed something

Can be fine as well, we actually use it at Taiko (and added this flag on our fork) when launching our chain and testnets, but we can just keep it on our fork if removing it is better here.

fjl commented 3 months ago

As @MariusVanDerWijden said, the flag only sets the starting price, and that price will start drifting as predictions are made. So configuring it is useless, because the config value doesn't stick.