search

ethereum / go-ethereum

Go implementation of the Ethereum protocol
https://geth.ethereum.org
GNU Lesser General Public License v3.0
47.78k stars 20.23k forks source link

Dead links for transaction call object #30214

Open Otto-AA opened 4 months ago

Otto-AA commented 4 months ago

Describe the bug

In several places the link https://geth.ethereum.org/docs/interacting-with-geth/rpc/objects is used to link to the transaction call object, but it does not exist anymore.

I could not find correct destination, where it describes this information, so I can't make a PR myself to fix it.

To reproduce

  1. Go to https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-eth
  2. Click on "Please see here for details."

Expected behavior

It should display information about the transaction call object.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

No response

Would you like to work on this issue?

s1na commented 4 months ago

Hm I found the commit where this file was deleted: https://github.com/ethereum/go-ethereum/commit/0378ccbe808b97fe6c03557c7d1879dc0be5b41e. @fjl do you remember why?

s1na commented 2 months ago

This page was re-added as part of #30476. Thanks for reporting!

Otto-AA commented 1 month ago

@s1na Hi, I just looked at this again and the links are still broken (see reproduction in initial issue).

When navigating via the menu on the left to "Interacting with geth" > "objects" it opens the page, but directly visiting the link forwards to /docs. So the page exists, but cannot be opened directly by clicking on a link.

s1na commented 1 month ago

@Otto-AA Both links in the Eth namespace page are working for me. Can you share the exact link that is failing?

Otto-AA commented 1 month ago

This link does not work: https://geth.ethereum.org/docs/interacting-with-geth/rpc/objects (redirects to https://geth.ethereum.org/docs)

It can be accessed via the menu navigation, but not when navigating to it with the url.

$ curl https://geth.ethereum.org/docs/interacting-with-geth/rpc/objects
Redirecting to /docs
s1na commented 1 month ago

@corwintines It is a strange issue. I could reproduce it. Can you please take a look?

Basically clicking on the objects link from the navigation menu goes to the page correctly. However once there if I simply refresh the page it will go to "docs index" page.