search

ethereum / go-ethereum

Go implementation of the Ethereum protocol
https://geth.ethereum.org
GNU Lesser General Public License v3.0
47.71k stars 20.19k forks source link

all: typos in comments #30779

Closed wangjingcun closed 3 days ago

wangjingcun commented 4 days ago

Since err != nil has been judged before, nil is returned directly here, which is more obvious, readable and less error-prone.

wangjingcun commented 4 days ago

I don't see any point in modifying the old accounts-files.

The typos might be worth fixing though

Should I roll back the relevant modifications in the accounts directory?

lightclient commented 4 days ago

@wangjingcun yes please, we will just accept the typos.

wangjingcun commented 4 days ago

@wangjingcun yes please, we will just accept the typos.

Reverted. Please review again.