search

ethereum / go-verkle

A go implementation of Verkle trees
The Unlicense
209 stars 63 forks source link

fix: typo of NewLeafNodeWithNoComms() #417

Closed agnxsh closed 9 months ago

agnxsh commented 10 months ago

Fixed the typo in https://github.com/ethereum/go-verkle/blob/master/tree.go#L312

jsign commented 9 months ago

@agnxsh, I think this PR was correct?

Actually, this makes me realize this is an API that I'd like not to be public -- feels to brittle. Anyway, that's another topic.

agnxsh commented 9 months ago

@agnxsh, I think this PR was correct?

Actually, this makes me realize this is an API that I'd like not to be public -- feels to brittle. Anyway, that's another topic.

oh sorry for closing it, i thought it was a trivial change, just caught my eye while going through the codebase, i can make a pr again

agnxsh commented 9 months ago

https://github.com/ethereum/go-verkle/pull/420 here's the revised pr