ethereum / grid

[DEPRECATED] Download, configure, and run Ethereum nodes and tools
https://grid.ethereum.org/
ISC License
175 stars 36 forks source link

feat: ignore flag if empty #518

Closed ryanio closed 5 years ago

ryanio commented 5 years ago

What does it do? Does it close any issues?

Removes trying to define default data directory and keystore directory across platforms, and instead introduces property ignoreIfEmpty to flag settings.

Closes one of the issues in #512

Pairs with https://github.com/ethereum/grid-ui/pull/159


To test, run this branch with the paired grid-ui branch and see what your values in Settings are for Geth for Data Directory and Keystore Directory. Clear them empty, and see if the generated flags hide --datadir and/or --keystoredir