ethereum / hevm

symbolic EVM evaluator
https://hevm.dev
GNU Affero General Public License v3.0
223 stars 45 forks source link

Fix nixpkgs ghc96 #479

Closed hellwolf closed 2 weeks ago

hellwolf commented 4 months ago

Description

To fix the upstream nixpkgs, I took few hours to tackle couple of issues I encountered.

I realized https://github.com/ethereum/hevm/pull/471 is ongoing. So this may be duplicate work, partially.

What I did:

  1. I did want to see if I could make cabal --allow-newer --enable-tests --enable-bench build all work. In doing so, I was guided by -Wunused-packages option to remove bunch of red-herring dependency issues.
  2. I fixed build errors due to newer packages or ghc 9.6, some already present in https://github.com/ethereum/hevm/pull/471
    • I did not use the test suite thoroughly, since I am not familiar with hevm test suite.
  3. update nixpkgs flake input.

Checklist

msooseth commented 2 weeks ago

Hi! #471 has been merged. Do you think there are things that would be of interest to port? For example the red herring dependencies you found? Let me know what you think,

Mate

hellwolf commented 2 weeks ago

Hi, I would really like to clean up the cabal file free of unused dependencies! I will work on this and send a patch.

msooseth commented 2 weeks ago

NICE. Thanks a lot! Looking forward :)

hellwolf commented 2 weeks ago

@msooseth https://github.com/ethereum/hevm/pull/518