search

ethereum / hevm

symbolic EVM evaluator
https://hevm.dev
GNU Affero General Public License v3.0
223 stars 45 forks source link

Update to GHC 9.6 #499

Closed blishko closed 3 weeks ago

blishko commented 1 month ago

Description

This finishes the work started in #471.

Checklist

msooseth commented 1 month ago

Let me know when this is ready for review! :) I'd be happy to review & merge.

blishko commented 3 weeks ago

@d-xo, I guess we can merge now, WDYT?

elopez commented 3 weeks ago

@blishko there's one last issue remaining, the redistributable files produced by nix contain references to the nix store due to how c++ / c++abi is now split. I'm hoping this fixes it and prevents the issue from going unnoticed again https://github.com/elopez/hevm/pull/4/commits/6575b73ca87ee6165739d88f2adc47562845a60f

Edit: it seems to work fine locally. The build CI uploads "nixful" binaries but that's because it doesn't use #redistributable. I expect the release CI to work fine with that patch.

d-xo commented 3 weeks ago

@elopez thats not a regression and I think it can be fixed in a separate pr. Let's merge this now. thanks for the work everyone,I think we have commits from almost every active hevm contributor on this branch ❤️