ethereum / hevm

symbolic EVM evaluator
https://hevm.dev
GNU Affero General Public License v3.0
235 stars 48 forks source link

Adding MacOS-ARM64 release build #504

Closed msooseth closed 3 months ago

msooseth commented 3 months ago

Description

This should finally make sure we release a MacOS ARM as well as x86 build. I will have to check it in a separate personal repo, as this requires a release to be made to check. Once it works there, I'll ask for review and merge.

Checklist

msooseth commented 3 months ago

Ah, seems to be working! See: https://github.com/msooseth/hevm/actions/runs/9943414569

The files are indeed what they are supposed to be:

$ unzip hevm-arm64-macos.zip
Archive:  hevm-arm64-macos.zip
  inflating: hevm-arm64-macos
$ file hevm-arm64-macos
hevm-arm64-macos: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>
$ unzip hevm-x86_64-macos.zip
Archive:  hevm-x86_64-macos.zip
  inflating: hevm-x86_64-macos
$ file hevm-x86_64-macos
hevm-x86_64-macos: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>

Can you please review and merge?

msooseth commented 3 months ago

I think you were all correct. I am trying to fix this thing now.... Apparently it wasn't right!

msooseth commented 3 months ago

@d-xo I have fixed what Martin asked for. However, I don't know how to name the files differently with the matrix, and then have a dependency for the last step of uploading the files for the release. It's probably possible with some yaml magic/meta-programming, but I am not sure how to do it. Do you wanna have a go at it?

msooseth commented 3 months ago

Note: it works correctly now, see: https://github.com/msooseth/hevm/releases/tag/release%2F14.0.0 All is built & uploaded. Build is now parallel, as requested!