Support memoryview - Githubissues

ethereum / hexbytes

Python `bytes` subclass that decodes hex, with a readable console output

MIT License

27 stars 19 forks source link

Support memoryview #22

Closed Uxio0 closed 2 years ago

Uxio0 commented 2 years ago

bytes can cast memoryview, so HexBytes should be able too

Uxio0 commented 2 years ago

@carver Do you think this makes sense? I had some issues with memoryview as I tend to use HexBytes anywhere where I used bytes

carver commented 2 years ago

Oof, that garbage GitGuardian Security checks made me think that the CircleCI had run 😠

Uxio0 commented 2 years ago

Nice, thanks! Would it be possible to get a new release with this?

carver commented 2 years ago

@kclowes would you take care of the release?

I just merged in the latest template changes, so it should prune the venv (although I think you said you might have to manually prune, which didn't make sense to me... but just a heads up).

kclowes commented 2 years ago

@kclowes would you take care of the release?

Yep, can do!

I think you said you might have to manually prune

Now that we're using the prune command in Manifest.in instead of recursive-exclude we don't need to do that any more. I think either the path was wrong or I was missing some detail in how recursive-exclude works.