ethereum / hexbytes

Python `bytes` subclass that decodes hex, with a readable console output
MIT License
27 stars 19 forks source link

Update mypy #25

Closed kclowes closed 2 years ago

kclowes commented 2 years ago

What was wrong?

hexbytes wouldn't install dev dependencies with the latest versions of Python.

How was it fixed?

Upgraded mypy, fixed some typing errors, fixed the doc build, fixed a few other misc. things that prevent releasing.

Added lint runs against all supported python versions because they're quick and I think it's a valuable smoke test.

To-Do

Cute Animal Picture

put a cute animal picture link inside the parentheses

kclowes commented 2 years ago

@fselmo This should be ready for one more look when you get a chance please 👀

fselmo commented 2 years ago

I think there's value in having a make lint command for local dev purposes, that runs with whatever python version you are on. So having a lint testenv would be nice to have:

[testenv:lint]
basepython=python
deps={[common-lint]deps}
commands={[common-lint]commands}
kclowes commented 2 years ago

That's a good point. I'll put it back. Thanks!