search

ethereum / hive

Ethereum end-to-end test harness
GNU General Public License v3.0
397 stars 449 forks source link

simulators/portal: add docker caching step for building rust simulator dependencies #1083

Closed acolytec3 closed 5 months ago

acolytec3 commented 5 months ago

Adds a caching step in the docker build process for the portal simulators to allow for quicker rebuilding of simulator containers when working on portal hive tests locally.

acolytec3 commented 5 months ago

@KolbyML Here's the PR we discussed. You can verify the speedup by building any of the portal test suites locally, and then commenting out any subset of the test suites and rebuilding.

KolbyML commented 5 months ago

The changes to all 3 dockerfiles should be the same, but currently all 3 docker files has different changes. I am assuming this is a issue with the PR.

acolytec3 commented 5 months ago

The changes to all 3 dockerfiles should be the same, but currently all 3 docker files has different changes. I am assuming this is a issue with the PR.

Have fixed this.

acolytec3 commented 5 months ago

@KolbyML any other feedback on this one?

KolbyML commented 5 months ago

@KolbyML any other feedback on this one?

It looks good just didn't get a chance to test it yet, I will test it today