ethereum / hive

Ethereum end-to-end test harness
GNU General Public License v3.0
397 stars 449 forks source link

simulators/rpc: make rpc suite post-merge #1117

Closed Rjected closed 3 months ago

Rjected commented 3 months ago

This makes the ethereum/rpc suite post-merge by setting the genesis and the environment variables. This is sort of a reth-specific fix, since our dev mode only works if the genesis is post merge. However, it doesn't seem like this should break other clients either.

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Generic High Entropy Secret | 855b2bf872181ef5ecd23ac792776dbb5421ec44 | simulators/ethereum/rpc/main.go | [View secret](https://github.com/ethereum/hive/commit/855b2bf872181ef5ecd23ac792776dbb5421ec44#diff-2eb7dae819d21ba5471337d95ae4faded5cc7d252025ca718a49d727f91c852bL40) | | [-](https://dashboard.gitguardian.com/workspace/255876/incidents/secrets) | | Generic High Entropy Secret | 855b2bf872181ef5ecd23ac792776dbb5421ec44 | simulators/ethereum/rpc/main.go | [View secret](https://github.com/ethereum/hive/commit/855b2bf872181ef5ecd23ac792776dbb5421ec44#diff-2eb7dae819d21ba5471337d95ae4faded5cc7d252025ca718a49d727f91c852bR32) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit) to catch secret before it leaves your machine and ease remediation. If this detection is a false positive, please contact Oleh Vasylenko (@aldekein) to fix it in the GitGuardian dashboard.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

marioevz commented 3 months ago

Hey @fjl do you know if it will be possible to merge with the false-positive found in the GitGuardian checks?

fjl commented 3 months ago

Yeah, sure! I don't think it will be a problem with GitGuardian.

fjl commented 3 months ago

I think this PR will break the tests for some other clients though, since they won't be producing blocks after the merge happened. Updating it properly for the merge is a lot of work, I tried...

I think we should actually deprecate this suite in favor of ethereum/engine, or maybe integrate some of the tests here into it. We also have rpc-compat which explores a lot of API edge cases. The ethereum/rpc suite was supposed to check end-to-end use cases of the RPC API, i.e. check functionality that normal apps actually use.

Rjected commented 3 months ago

I think this PR will break the tests for some other clients though, since they won't be producing blocks after the merge happened. Updating it properly for the merge is a lot of work, I tried...

I think we should actually deprecate this suite in favor of ethereum/engine, or maybe integrate some of the tests here into it. We also have rpc-compat which explores a lot of API edge cases. The ethereum/rpc suite was supposed to check end-to-end use cases of the RPC API, i.e. check functionality that normal apps actually use.

Makes sense, I'd be very supportive of deprecating this suite / incorporating the logic into other suites. We do run the other test suites as well, so I'm going to close this PR