search

ethereum / hive

Ethereum end-to-end test harness
GNU General Public License v3.0
383 stars 437 forks source link

clients/ultralight: set network radius in script #1131

Closed ScottyPoi closed 12 hours ago

ScottyPoi commented 3 days ago

Updates the startup script for ultralight at clients/ultralight/ultralight.sh

Adds command line flags to set the network radius for ultralight nodes. Recent updates to Ultralight code cause some hive tests to fail if these flags are not set.

KolbyML commented 3 days ago

I am confused why do we need magic flags, to pass tests which should pass with default settings?

KolbyML commented 2 days ago

I am confused why do we need magic flags, to pass tests which should pass with default settings?

what are default settings? is there an expected default radius?

Wait how did ultralights radius used to work and how does it now?

Trin/Fluffy/Shisui start at 100% and start lowering once their database is filled to the storage limit

ScottyPoi commented 12 hours ago

Okay. I thought about it, and I'll adjust things in the ultralight code instead.