search

ethereum / interfaces

Interface Specifications inside Ethereum
36 stars 175 forks source link

Rename eth_sendRawTransaction to eth_sendSignedTransaction #10

Open Georgi87 opened 7 years ago

Georgi87 commented 7 years ago

The naming for the RPC call eth_sendRawTransaction is misleading as this call allows to send a signed transaction. The term raw is used in the context of transactions for unsigned data (raw transaction hash). Changing the RPC name to eth_sendSignedTransaction would make the usage more clear and prevent misuse.

frozeman commented 7 years ago

I fully support this and in web3.js 1.0 it will be already called eth.sendSignedTransaction() @bas-vk @obscuren can we change that and deprecate the old name?

The name was initially given by @silentcicero who just came up with the name and i didn't had much time to think about a better one back then.

kumavis commented 7 years ago

parity recently introduced eth_submitTransaction as an alias to eth_sendRawTransaction https://github.com/ethcore/parity/blob/8404edb656693270ec1cd3956d204f625d28ec7c/rpc/src/v1/traits/eth.rs#L108-L109

Georgi87 commented 7 years ago

Good to see parity also sees this as an issue. I think the difference between submitTransaction and sendTransaction is not really obvious with this naming but it is much better than sendRawTransaction.