search

ethereum / keymanager-APIs

Collection of RESTful APIs provided by Ethereum consensus keymanagers
https://ethereum.github.io/keymanager-APIs/
Creative Commons Zero v1.0 Universal
38 stars 19 forks source link

Add graffiti API #63

Closed nflaig closed 1 year ago

nflaig commented 1 year ago

Add keymanager API to manage graffiti per validator.

The rationale for this is similar as for gas limit (https://github.com/ethereum/keymanager-APIs/pull/39), the graffiti is already part of proposer config file and it should be quite simple to implement (https://github.com/ChainSafe/lodestar/pull/6083).

dappnodedev commented 1 year ago

It would be awesome to have this! In Dappnode we could add the feature of editing the graffiti individually from the Web3Signer package UI!

rolfyone commented 1 year ago

It would be awesome to have this! In Dappnode we could add the feature of editing the graffiti individually from the Web3Signer package UI!

Given web3signer is only signing (not creating blocks) it won't be able to control graffiti, you'd still need to have the CL with keymanager and control the graffiti through that...

I realised that may have been random... the time graffiti is supplied is when the validator node makes a call to https://ethereum.github.io/beacon-APIs/#/ValidatorRequiredApi/produceBlockV3 (all versions, blinded, unblinded etc allow supplying graffiti to the BN)

Once the block is produced, that's what is then passed to the web3signer for signing, complete with the graffiti that was included during that create unsigned call...

rolfyone commented 1 year ago

Any further comments? Looks like at least Prysm/teku happy... @michaelsproul or @jimmygchen , @dapplion, @nflaig ?