search

ethereum / lahja

Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio
MIT License
394 stars 19 forks source link

Removed connect_to_endpoint and connect_to_endpoints_nowait API #137

Closed cburgdorf closed 5 years ago

cburgdorf commented 5 years ago

What was wrong?

  1. Usage of connect_to_endpoints_nowait was discouraged and Trinity does not need it anymore

  2. Having variadic connect_to_endpoints and non-variadic connect_to_endpoint is unnecessary as the former is a superset of the latter.

How was it fixed?

Removed both APIs.

Bonus: _await_connect_to_endpoint throws earlier in case of errors now

Cute Animal Picture

put a cute animal picture link inside the parentheses