graceful failure if IPC file is missing

ethereum / lahja

Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio

MIT License

394 stars 19 forks source link

graceful failure if IPC file is missing #144

Closed pipermerriam closed 5 years ago

pipermerriam commented 5 years ago

What was wrong?

If for some reason the IPC file is missing during server shutdown, the asyncio endpoint throws a FileNotFoundError while trying to remove it.

How was it fixed?

Catch this error and silence it when shutting down the server.

Cute Animal Picture

llamas2

cburgdorf commented 5 years ago

I'm going to merge this one because I want to see if it triggeres a new RTD build (turns out they were broken for two months and I just attempted to fix it)

cburgdorf commented 5 years ago

@pipermerriam ok, it's still not triggering new RTD builds. I'm not sure but maybe I'm missing some rights to make configurations on GitHub? I think you also magically fixed that for Trinity. Can you take a look?

pipermerriam commented 5 years ago

Should be fixed now