search

ethereum / meteor-dapp-wallet

This is an archived repository of one of the early Ethereum wallets.
https://ethereum.org/en/wallets/find-wallet/
GNU General Public License v3.0
599 stars 410 forks source link

Show localised error when user rejects transaction in MetaMask #464

Closed ahoppen closed 6 years ago

ahoppen commented 6 years ago

At the moment, when the user rejects a transaction from within MetaMask, a stack trace of the error within the MetaMask extension is displayed. This gives very little value to the user as to what actually happened.

Checking for setTxStatusRejected in the error message seems to be the safest way to check if the transaction was rejected from within MetaMask that works in all browsers since Firefox clips the start of the error message.

I have translated the new message to German but left the other languages untouched since I speak neither of them. I don't know what the standard policy for that is and if they would be required for the PR to be accepted.

ahoppen commented 6 years ago

The entire check is pretty tailor-made for MetaMask, since I'm checking for setTxStatusRejected, which is a MetaMask-internal function that occurs in the error's stack trace. I can remove the reference to MetaMask, but don't think this will make the check any more general.

evertonfraga commented 6 years ago

@ahoppen alright. should we have any other wallet with similar functionality, we make the text more general.

Hasanyeach commented 6 years ago

Saya tidak bisa mendownload metamask melalui smartphone 😑