ethereum / meteor-dapp-wallet

This is an archived repository of one of the early Ethereum wallets.
https://ethereum.org/en/wallets/find-wallet/
GNU General Public License v3.0
599 stars 410 forks source link

support configurable settings #475

Open hackmod opened 6 years ago

hackmod commented 6 years ago

WARNING

[WIP] Please do not merge it

support configurable settings using meteor --settings like as meteor --settings local.json or meteor-build-client blahblah -s settings.json

Done

ToDo

example

this is a sample case for the Callisto Network.

{
    "public": {
        "title": "Callisto Network",
        "unit": "CLO",
        "ether": "CLO",
        "Ether": "CLO",
        "ethereum": "callisto",
        "Ethereum": "Callisto",
        "walletName": "CLO Wallet",
        "walletDescription": "The CLO Wallet",
        "walletKeywords": "wallet, dapp, CLO, callisto",
        "downloadUrl": "https://github.com/EthereumCommonwealth/mist/releases",
        "blockExplorerUrl": "https://cloexplorer.net",
        "blockExplorerAddrUrl": "https://cloexplorer/addr/",
        "geth": "geth",
        "gethIpc": "geth.ipc",
        "gethConnectionUrl": "ws://localhost:8546"
    }
}

further more, multi configurations also possible.

{
    "public": {
        "networks": {
            "ethersocial": {
                "title": "EtherSocial Network",
                "noUsePrice": false,
                "ticker": "ETH",
                "unit": "ESN",
                "ether": "esn",
                "Ether": "ESN",
                "ethereum": "ethersocial",
                "Ethereum": "Ethersocial",
                "walletName": "ESN Wallet",
                "walletDescription": "The ESN Wallet",
                "walletKeywords": "wallet, dapp, ESN, ethersocial",
                "downloadUrl": "https://github.com/ethersocial/mist/releases",
                "blockExplorerUrl": "https://ethersocial.net",
                "blockExplorerAddrUrl": "https://ethersocial.net/addr/",
                "geth": "gesn",
                "gethIpc": "gesn.ipc",
...
hackmod commented 6 years ago
evertonfraga commented 6 years ago

Hi @hackmod, thanks for the contribution.

This is something we have to consider. How do you use Geth in Callisto network? Does the network aims to comprise Dapps as well (full mist browser) or wallet only?

hackmod commented 6 years ago

How do you use Geth in Callisto network?

Callisto support their modified clients, both parity based and geth based client (go-callisto). basically, Callisto is a go-ethereum based off ethereum chain, aim on Dapp ecosystem.

evertonfraga commented 6 years ago

So it's not just a matter of changing the network ID to account for Callisto network, it requires binary management. Did you fork and modified Mist as well?

hackmod commented 6 years ago

So it's not just a matter of changing the network ID to account for Callisto network, it requires binary management. Did you fork and modified Mist as well?

basically yes. Other mist+meteor-dapp-wallet based off wallet change their clientBinaries.json like as https://github.com/ethersocial/mist/blob/develop/clientBinaries.json and change ether unit like as https://github.com/ethersocial/mist/commit/4c834f917689ea6912303b25ce5ec2f9f55a3f51#diff-0158e844f76fdda3e7e216d93e8b1b4fR30

but as you can see, it is almost trivial change, I think.

hackmod commented 6 years ago

rebased onto master

hackmod commented 6 years ago

updated / rebased

evertonfraga commented 6 years ago

Alright, great. we're at capacity dealing with the next mist release (already in master branch, if you want to test).

After that I'll come back to this PR and assess it. Thanks for the contribution :)

Adyfamba commented 5 years ago

Hello..