Hide gas section if isMist

ethereum / meteor-dapp-wallet

This is an archived repository of one of the early Ethereum wallets.

https://ethereum.org/en/wallets/find-wallet/

GNU General Public License v3.0

599 stars 410 forks source link

Closed ryanio closed 5 years ago

ryanio commented 6 years ago

Since we are now handling gas inside the new SendTx window in Mist, this PR hides the gas section on the Send tab if isMist

evertonfraga commented 6 years ago

LGTM

evertonfraga commented 6 years ago

Hm, although it looks good, i think it's fundamentally wrong. isMist checks wether the dapp is being loaded from electron, mist or wallet.

wolovim commented 6 years ago

@evertonfraga isn't hiding the gas selector the desired behavior on both mist and EW once the new standard/priority fee is merged in?

@ryanio realized there's another gas slider in the app on the contract deploy page. may be worth a quick search to verify that's the only other one.

ryanio commented 5 years ago

I'm not seeing a gas slider on contract deployment? I believe uses same send.html

I merged this commit into #487 so once discussion here is concluded we can close this PR.

evertonfraga commented 5 years ago

So I'd say it is solved :)