search

ethereum / meteor-package-accounts

15 stars 244 forks source link

Falsy check leading to bugs #9

Closed Slava closed 6 years ago

Slava commented 6 years ago

https://github.com/ethereum/meteor-package-accounts/blob/5cb66b3ad582b01f73694ea10abc754fb5eaae97/accounts.js#L92

On this line the check will skip accounts with balance 0, giving accounts with balance 0 no chance to "reactivate"

Slava commented 6 years ago

Hmm, after closer inspection, I see that the intended way to store the balance is in strings.