ethereum / mist

[DEPRECATED] Mist. Browse and use Ðapps on the Ethereum network.
http://ethereum.org
GNU General Public License v3.0
7.44k stars 2.12k forks source link

Not able to import used presale wallet #182

Open TT1943 opened 8 years ago

TT1943 commented 8 years ago

I am used to import part of my presale ethers using Kraken's presale importing tool. There is 0.07 Ether left in my presale file. Trying to import this wallet into Mist gives me "wrong password" error.

frozeman commented 8 years ago

than thats probably it ;) -> wrong password.

It works for my one and others..

TT1943 commented 8 years ago

@frozeman No. If I try to re-import using Kraken's pre-sale import tool, my password is correct, and it shows I have 0.07 Ether left. If however I import the same file with same password, Mist gave me "wrong password" message.

alexvandesande commented 8 years ago

This is the second user reporting a similar issue.

I'll implement a "show password" feature on the next version, so we can be sure it's not a password typing error..

alexvandesande commented 8 years ago

@TT1943 unless there's some personal information, would you mind sweeping the money out of that account and then providing us the wallet and password to help us debug it?

lpmorin commented 8 years ago

Yep, got the same bug

alexvandesande commented 8 years ago

Louis we are looking for a presale wallet giving that error to be able to debug it. Have you been able to empty it? If so, would you volunteer your file?

On Feb 20, 2016, at 23:53, Louis-Pierre Morin notifications@github.com wrote:

Yep, got the same bug

— Reply to this email directly or view it on GitHub.

TT1943 commented 8 years ago

@alexvandesande sorry, the password I am using is personal, so might not proper to share it with you even if I emptify it. May be you could try to compare your code with what is written by Kraken to see whether there is any difference. The Kraken importing tool is open source too.

frozeman commented 8 years ago

@TT1943 mist works completely different than the kraken tool and has other layers in between which could cause the issue.

The only real way to try it is when i can test it on my system myself. Though i fully understand that you might not want to share your password. Maybe we find somebody else, who has a generated password, which he is ok to give away..

lpmorin commented 8 years ago

Sorry, It has a non random password.

Thanks

LP …………………………………………….. Louis-Pierre Morin tel: 514.317.2316 - cel: 514.815.4889 lpmorin@proxee.ca - skype: nirom4889 www.proxee.ca

On Feb 21, 2016, at 8:42 AM, Alexandre Van de Sande notifications@github.com wrote:

Louis we are looking for a presale wallet giving that error to be able to debug it. Have you been able to empty it? If so, would you volunteer your file?

On Feb 20, 2016, at 23:53, Louis-Pierre Morin notifications@github.com wrote:

Yep, got the same bug

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/ethereum/mist/issues/182#issuecomment-186824799.

uwefassnacht commented 8 years ago

@alexvandesande @frozeman I have the exact same issue described. I'd b happy to donate my presale wallet to science ;-) It's (almost) empty and the password is generated (has all sorts of special characters in it). Maybe that's the issue? Where do you like me to send the file to?

frozeman commented 8 years ago

fabian at ethdev.com please thank you!

xkmo commented 8 years ago

I have the same issue. My password is generated by Safari/Keychain Access consisted of uppercase and lowercase letters, hyphens and numbers.

jhansikiraani commented 8 years ago

I have the same issue. Has the issue been resolved yet?

ManfredKarrer commented 8 years ago

I (and another friend who reported me) had also a problem importing the crowd sale file (wrong password). Using OSX 10.9.5. Tried with 3 different presale files. Using kryptokite wallet it worked than luckily. Please fix that urgently! It's really a shocking experience!

Aranad commented 8 years ago

I'm getting this problem too, can't import presale wallet into mist due to wrong password error, but I know the password is correct because I can import the presale wallet into geth no trouble. I'm on 64 bit Linux Mint 17 with kernel 3.13. It was a shocking experience for me too! It took a long time to figure out how to install geth and sync the blockchain to see that it worked ok there.

Aranad commented 8 years ago

I just noticed the comment above about passwords containing "$", my failing password has a $ in it too...

chtmorris commented 8 years ago

Likewise. I just spent the morning freaking out. After using, https://github.com/ryepdx/pyethrecover I found that my password is in fact correct, despite Mist telling me otherwise.
Note: I use an exclamation mark in my password.

cayblood commented 8 years ago

@frozeman Could it be that somehow pasting the contents of the clipboard is not quite working right in Mist? I was using a password manager to copy my password to the clipboard and then paste it into the password field.

crmn111 commented 8 years ago

I have the same issue, i will now try kraken to get my presale wallet in there, hopefully it will work there

mrfelton commented 8 years ago

Same issue for me. I checked my password using pyethrecover.py and it is indeed set to what I thought it was (after much worry). I've also checked that I can get the private key using pyethsaletool.py and that worked too. Mist tells me that the password is incorrect. The only character in my password that I could think might be causing the issue is the ! character.

alexvandesande commented 8 years ago

If you can use the command line then you can import your presale using geth as this is likely a Mist issue. Follow the instructions at ethereum.org/cli and ethereum.org/ether

Sent from my iPhone

On Mar 12, 2016, at 17:49, Tom Kirkpatrick notifications@github.com wrote:

Same issue for me. I checked my password using pyethrecover.py and it is indeed set to what I thought it was (after much worry). I've also checked that I can get the private key using pyethsaletool.py and that worked too. Mist tells me that the password is incorrect. The only character in my password that I could think might be causing the issue is the ! character.

— Reply to this email directly or view it on GitHub.

ManfredKarrer commented 8 years ago

@alexvandesande: I really would expect that Ethereum devs gives higher priority to that issues! It does not give a good impression to the projects quality and reputation to react after 3 weeks to such an urgent issue by referring to the command line tools. And you know, if 1 person reports an issue there are other 10 who don't. So the invisible damage is much larger.

frozeman commented 8 years ago

Can you try the latest release? https://github.com/ethereum/mist/releases/tag/0.5.2

Aranad commented 8 years ago

Nope same result with 0.5.2 unfortunately :-(

jhansikiraani commented 8 years ago

Is anyone getting the "your computers time is out of sync" error when updating from 0.5.1 to 0.5.2?

jhansikiraani commented 8 years ago

Never mind. I fixed my clock and now it working fine. Thanks

crmn111 commented 8 years ago

Syncing my clock didn't help me... in the end i imported the wallet using the command line tools as kraken didn't work for me either ... UX of that kind of sucked ;-)

crmn111 commented 8 years ago

(i used 0.5.1 fyi)

vanjan commented 8 years ago

This is still broken in 0.5.2 on OS X. Kraken is able to open my wallet, Mist claims 'wrong password'

chtmorris commented 8 years ago

This is still broken for me too on 0.5.2 on OSX. Mist claims 'wrong password'

frozeman commented 8 years ago

Can you try using the command line and see if you can import? https://github.com/ethereum/go-ethereum/wiki/Command-Line-Options#accounts

You can use the binary in Ethereum-Wallet.app/Contents/Frameworks/node/geth/geth

vanjan commented 8 years ago

It worked via the command line.

You should consider adding a warning about this on the front page as I'm sure this is causing a lot of anxiety to your users.

scrussell24 commented 8 years ago

Same issue. My password also contains a $ character.

misterdna commented 8 years ago

I'm one more person unable to use the GUI wallet on Mac to access my presale wallet, due to an erroneous "wrong password" response (it has several "special characters").

rvm1019 commented 8 years ago

I've tried a number of times to import my new pre-sale ether through mist wallet (on Mac) and it's still not working (wrong password error)...however it does work on the kraken site, so I know it's the correct pw. The pw has one "!" and the rest are characters and numbers all meeting the criteria.

hiddentao commented 8 years ago

I had this problem too. I switched to the command-line (geth) and my password worked. My password has special characters within it.

uwefassnacht commented 8 years ago

Same here. I can import the pre-sale wallet fine with kraken or via the command line. The special characters that it contains are % and /.

lpmorin commented 8 years ago

I had special caracters as well in mine

hiddentao commented 8 years ago

I spent some time testing out the latest mist import code and can confirm that inputting the password (with special characters) now works for me. Even copy-pasting the password into the field works. I modified geth so that it output the password sent to it from Mist and it is indeed receiving exactly what the user puts in.

I'm running on OS X. I'm wondering if this is only broken on other platforms. I'm now investigating to see whether it still works if I build the final distributable.

Has anybody else tried with the latest master?

hiddentao commented 8 years ago

I built the Mac distributable. So far, if I run it from the command-line password input works. If I double-click on the .app and run it directly password input fails.

hiddentao commented 8 years ago

I think I have figured out why this is happening.

When launching the app directly (i.e. not from terminal) geth is unable to use its preferred terminal library and so falls back to another input method, see https://github.com/ethereum/go-ethereum/blob/master/cmd/utils/cmd.go#L83. This results in the carriage return (\n) getting appended to the password as it's received and processed by geth, which results in an incorrect password error.

hiddentao commented 8 years ago

This is ultimately an issue in geth since I get the same problem using command-line geth if I disable it's preferred terminal input parser. I've raised a PR against geth -> https://github.com/ethereum/go-ethereum/pull/2369.

@frozeman If you like I can build geth with the fix for OS X and raise a PR for mist to replace the currently bundled geth.

frozeman commented 8 years ago

@hiddentao thank you for figuring this out. Can you build the geth for windows, mac and linux?

hiddentao commented 8 years ago

@frozeman Further discussion on the PR I raised indicates that (a) I need to test the fix on Windows to make sure it works there too, and (b) there is another PR that also fixes this issue and with tests too. As I commented there I'm wondering whether a better overall fix would be to make it possible to specify a password directly as part of the geth wallet import command. This would have the added benefit of making it easier to do the import from Mist.

Aranad commented 8 years ago

Can we have a new release built with the updated geth in it please?

frozeman commented 8 years ago

This change may affect other things and the go team is looking into this. Development cycles until release take a bit longer as some of us would like, but thats necessary to ensure we don't break other things.

If you need to import the presale wallet, you can always use the command line options: https://github.com/ethereum/go-ethereum/wiki/Command-Line-Options#accounts

ghost commented 8 years ago

Hey team - just letting you know that I hit this issue when importing my presale wallets today. No issues importing with geth though.

Recognise there may be some complexity in fixing this completely in the GUI.. but anything that can be done to make it a little less heart-stopping for users would be great - even if it's blocking imports into Mist and sending users to geth when a special character is entered.

Best of luck rectifying!

e: To provide some further information: OSX 10.11.3 Mist 0.5.2 Password contained a few specials: ~!?

guiambros commented 8 years ago

Same problem here with 0.5.2 running on Linux. Password has special characters ")". 100% sure the password was correct (copy and paste).

I was able to import via geth wallet import wallet.json without any problems.

RCasatta commented 8 years ago

Mist 0.6.0 Mac Os X geth 1.3.5

I created an account with geth, send some ether on it, trying to move them with Mist give me wrong password. Trying to unlock the account from geth command line works so the password is correct

alexvandesande commented 8 years ago

The wallet is already at 0.7.1, this issue has been addressed on more recent versions.