search

ethereum / pm

Project Management: Meeting notes and agenda items
Other
1.59k stars 325 forks source link

Breakout-room discussion #8 (London Infrastructure Readiness) #308

Closed tvanepps closed 3 years ago

tvanepps commented 3 years ago

Date and Time

Meeting Date/Time: Friday, May 7 at 1400 UTC Meeting Duration: 60 mins Location: Will be shared in the Infrastructure channel of the EthR&D discord channel Recording: https://youtu.be/qce2M4ot8ls

Agenda

Next meeting - date/frequency?

Anything else? (Leave a comment)

timbeiko commented 3 years ago

One thing to go over is JSON RPC support for 1559. See this EthMagicians discussion.

MicahZoltu commented 3 years ago

Geth team position on JSON-RPC naming: https://gist.github.com/karalabe/1565e0bc1be6895ad85e2a0116367ba6

karalabe commented 3 years ago

Also note, the above position also has a section on the header field rename. That's not about what name we like, rather why we think any name change is bad, so please do read that part too.

jochem-brouwer commented 3 years ago

We have had a discussion on EIP1559 on ETH R&D to change some stuff which has to do with the gasTarget/gasLimit change, see this PR https://github.com/ethereum/EIPs/pull/3552, probably agenda the item to discuss/confirm these changes.

spalladino commented 3 years ago

I'm curious about how the existing gas price oracles (ethgasstation, gasnow, blocknative, etc) are adapting to 1559 if at all, since several clients depend on them to decide on gas price to use. Should they be included in the discussion?

tvanepps commented 3 years ago

I'm curious about how the existing gas price oracles (ethgasstation, gasnow, blocknative, etc) are adapting to 1559 if at all, since several clients depend on them to decide on gas price to use. Should they be included in the discussion?

Yes definitely - blocknative was included in our initial outreach, but I can definitely reach out to the others.

timbeiko commented 3 years ago

Here are my high-level notes from the call:

  1. We agreed to keep the gasLimit (and not target) in the block. We will reach out to miners directly to tell them to target a 2x'd gas limit on the fork block. We merged @lightclient's PR for this: https://github.com/ethereum/EIPs/commit/67d0d75f6393f6a109f2dc81cffc1e6541fb7aa3

  2. We agreed to have the first block with a base fee be the fork block, and not have the fork block assume the parent had a base fee set at the minimum level. We opened a PR for this: https://github.com/ethereum/EIPs/pull/3556

  3. We'll open a PR against 1559 to add the names of the JSON RPC fields to the EIP directly for clarity. Specifically, we'll use TBA.

  4. For the rest of the JSON RPC changes, we'll spec the diff outside of EIP-1559. We can either use the eips repo (e.g. https://eips.ethereum.org/EIPS/eip-3041) or the eth1-specs repo where we're starting to move things over. Either option probably works, but we currently don't have anyone to do this. If someone wants to take this on, please ping me. Funding is available for this.

  5. I've update the Baikal spec to follow this. Note that (2) will change the commit hash for 1559, but clients already implement things this way, so they will not need to change their implementation.

  6. We didn't decide on if/when the next call would happen. We'll see where we are at on next week's AllCoreDevs.

timbeiko commented 3 years ago

Recording of the call available at https://youtu.be/qce2M4ot8ls