ethereum / populus

The Ethereum development framework with the most cute animal pictures
http://populus.readthedocs.org/
321 stars 321 forks source link

add abi back to output selection #402

Closed pipermerriam closed 6 years ago

pipermerriam commented 6 years ago

fixes #401

What was wrong?

abi was not being included in the output for compilation

How was it fixed?

Added abi back to the output values.

Cute Animal Picture

05286f744fa749b2ce38d07e116b3981

veox commented 6 years ago

I've tested this locally; I'm afraid CI won't indicate failure, since the relevant test tries populus init, but not populus compile or running the greeter tests.

evm seems not to include evm.bytecode.linkReferences; so running populus compile results in same case of linkrefs missing (as in issue #387).

Just adding abi (that was missing in PR #399 - sorry, didn't try pytest) might help. Currently investigating...

pipermerriam commented 6 years ago

@veox going to expand test suite to cover latest solidity.