search

ethereum / populus

The Ethereum development framework with the most cute animal pictures
http://populus.readthedocs.org/
321 stars 321 forks source link

More complete solc v0.4.19 support (for "bytecode/linkrefs not found" cases) #404

Closed veox closed 6 years ago

veox commented 6 years ago

Closes #403 as superceded.

What was wrong?

PR #399 was a superficial fix that didn't really test against solc v0.4.19.

PR #403 missed a few places where outputSelection was specified explicitly.

How was it fixed?

Built on-top of PR #403 (relevant commits cherry-picked).

This adds the missing parts.

The work up to this can be seen in this branch of mine. There are a lot of commits there that "seem" to help with Travis failing tests; these, however, seem not to be required. (These were mostly adding visibility specifiers to functions - I have no idea why adding those helped tests pass.)

What could still be wrong?

This edits the default user config, v7. Possibly, it should have been a version bump to config v8 instead?..

Cute Animal Picture

source

veox commented 6 years ago

OK to close if not needed.

veox commented 6 years ago

Two failing builds are both of the test_wait_for_connection_success variety. Not unexpected with a build matrix this big.

pipermerriam commented 6 years ago

Closing now. Repplaced by https://github.com/ethereum/populus/pull/403 which is almost passing.