search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
316 stars 85 forks source link

Create separate repository for Portal test vectors #227

Closed kdeme closed 9 months ago

kdeme commented 1 year ago

Currently test vectors are added in *.md files within this repository. This was the fastest way to get started with the few tests we had back then.

More and more test vectors are being added, and I think we are at the point where it would be beneficial to look into creating a separate repository and defining a way (naming convention, file format, etc.) on how to store those test vectors in that repository. This is not only useful for the different clients, but also for portal-hive.

We can draw some inspiration perhaps from the consensus test vectors: https://github.com/ethereum/consensus-spec-tests/tree/master

For Fluffy, we are already using a separate repository with the test vectors stored in files: https://github.com/status-im/portal-spec-tests/

I'm not sure if it is fully consistent everywhere, and if it is the format we prefer. But if wanted we can start from that one (and move it).

pipermerriam commented 9 months ago

This is done now?

pipermerriam commented 9 months ago

https://github.com/ethereum/portal-spec-tests/