search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
286 stars 79 forks source link

Clarify slot to be used in `OptimisticUpdate` content key #228

Closed acolytec3 closed 9 months ago

acolytec3 commented 10 months ago

There is some ambiguity in the spec related to the optimistic_slot in the LightClientOptimisticUpdate key and this adds clarification that this slot should match the slot of the attested header in the requested LightClientOptimisticUpdate (which on best case will always be 1 slot behind the current slot as computed by the node's local clock).

acolytec3 commented 9 months ago

What about LightClientFinalityUpdate, my assumption is that we want to use the signature_slot there as well?

I'm not 100% sure since FinalityUpdates only get produced once per epoch in the CL spec. I think we should handle that in a separate PR once we come to agreement.