search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
316 stars 85 forks source link

offer/retrieval union content types splitted into separate types #262

Closed mynameisdaniil closed 10 months ago

mynameisdaniil commented 10 months ago

I propose splitting union offer/retrieval types into separate types. Rationale: they are different types, have different set of fields and different purpose, handled by a different branches of code. While this slightly bulks-up the spec it simplifies the code and makes understanding of the code more straightforward.

mynameisdaniil commented 10 months ago

@pipermerriam Well, It turns out that you already did what I was going to do with this PR, so it is mainly text formatting one :-)