Make Nibbles encoding more compact

ethereum / portal-network-specs

Official repository for specifications for the Portal Network

316 stars 85 forks source link

Closed morph-dev closed 9 months ago

morph-dev commented 9 months ago

Instead of storing nibbles and length separately, this proposal is to store encode them together.

Benefits are:

Previously, decoding is_odd_length is required in order to correctly decode path. Now they are encoded/decoded together.
More compact encoding (no need to waste 4 bytes that are always the same)
More aligned to MPT encoding of nibbles

mynameisdaniil commented 9 months ago

@morph-dev Sorry I didn't see this PR. I'll check test vectors later and we can merge it afterwards.

morph-dev commented 9 months ago

@morph-dev Sorry I didn't see this PR. I'll check test vectors later and we can merge it afterwards.

@mynameisdaniil did you have time to check them?

@pipermerriam Can you review this PR and merge it if there are no concerns?

mynameisdaniil commented 9 months ago

@morph-dev I'll do it right now and merge this branch once I'm done