search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

Add ContentNotFoundError #276

Closed njgheorghita closed 1 month ago

njgheorghita commented 8 months ago

Resolves #256

It's probably worth previewing the openrpc.json inside the playground. I spent some time trying to format the traceResultObject, but wasn't able to find a great option. afaict, we're stuck with an any object inside Error's "data" field - which doesn't offer any "pretty" display options.

njgheorghita commented 8 months ago

I have spent a fair amount of time trying to figure out how to flatten the json for the "data" field inside the error when it's rendered inside the playground. As far as I can tell there is no way to achieve this. It's not ideal, but it's also fairly trivial to flatten the json inside the playground after the endpoint has been rendered. I'm not too keen on spending anymore time trying to figure this out, so I'm in favor of moving ahead with this for the time being and revisiting the render issue down the road

acolytec3 commented 1 month ago

I think I may have resolved the issue with the data presentation for the trace object in my version of this under #343

njgheorghita commented 1 month ago

closing in favor of #343