ethereum / portal-network-specs

Official repository for specifications for the Portal Network
316 stars 85 forks source link

refactor(history-network): rename master accumulator #286

Closed ogenev closed 7 months ago

ogenev commented 7 months ago

We will have more than one header accumulator for verifying the canonicalness of history headers:

This PR proposes to rename MasterAccumulator to MergeAccumulator to make the name less confusing and more clear.

ogenev commented 7 months ago

I don't find MergeAccumulator particularly more clear.

It does not clarify that it is the accumulator for pre-merge data. And merge could also just mean something specifically regarding the accumulator itself.

What about PreMergeAccumulator, for pre-Capella headers it will be PreCapellaAccumulator (beacon state historical_roots) ?

Do you have any suggestions?

kdeme commented 7 months ago

What about PreMergeAccumulator, for pre-Capella headers it will be PreCapellaAccumulator (beacon state historical_roots) ?

Yes, PreMergeAccumulator would be better.

I would not create an additional name for the historical_roots and the historical_summaries. I'd just keep those names from the consensus specs.

ogenev commented 7 months ago

Yes, PreMergeAccumulator would be better.

Updated to PreMergeAccumulator.

ogenev commented 7 months ago

Added a new commit to rename theAccumulatorProof.