search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

Remove ByteList alias and fix Nodes reply to 1 response max #318

Closed kdeme closed 5 months ago

kdeme commented 5 months ago

This doesn't really change anything to what the clients currently have implemented.

Might want to review in the future some of the sizes of the ByteLists used but for now no functional change on this.

acolytec3 commented 5 months ago

What is the significance of making the bytelists max size 2048? I'm assuming I've just missed conversations along the way but not sure why we are doing this specific change.

kdeme commented 5 months ago

What is the significance of making the bytelists max size 2048? I'm assuming I've just missed conversations along the way but not sure why we are doing this specific change.

This is not a change. It is only semantics. We had ByteList defined as List[uint8, max_length=2048] and used that one all over the place. But the SSZ specification already has ByteList[N] defined. So this current alias is confusing as with SSZ specs in mind it might look like a ByteList with undefined limit, which is not allowed.