search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

Rework the Portal Wire Protocol spec language for clarity #319

Closed pipermerriam closed 3 months ago

pipermerriam commented 5 months ago

What was wrong

I made a bunch of edits to the wire protocol spec here https://github.com/KolbyML/EIPs/pull/2

These changes needed to be backported

Changes are things like using more consistent language and ensuring that concepts are introduced in the correct order.

How was it fixed

I copy/pasta

kdeme commented 5 months ago

Oops, I meant to review this PR here but accidentally reviewed it at https://github.com/KolbyML/EIPs/pull/2

KolbyML commented 5 months ago

One concern is some of the links I had to update to link to the local copies in the EIPs repo, so if we are fine with the broken links in this PR as it is now, I think it is fine to merge

kdeme commented 5 months ago

One concern is some of the links I had to update to link to the local copies in the EIPs repo, so if we are fine with the broken links in this PR as it is now, I think it is fine to merge

We should fix that here, the links in the portal specs should remain working.

pipermerriam commented 5 months ago

I'll cleanup the links after today's call

pipermerriam commented 3 months ago

I believe this is ready for merge