search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

feat(json-rpc): add `portal_beaconFinalizedStateRoot` JSON-RPC endpoint #331

Open ogenev opened 3 months ago

ogenev commented 3 months ago

A propose to add the portal_beaconFinalizedStateRoot endpoint to beacon JSON-RPC specs.

We already use this endpoint in Trin and it will be useful in hive when testing if a node keeps up with the finalized head.

acolytec3 commented 3 months ago

Did we ever decide whether we were going to add full-featured endpoints for beacon network stuff? I know @kdeme mentioned supporting a subset of the actual beacon endpoints specific to what we could return from Portal (e.g. /eth/v1/beacon/light_client/finality_update being the most relevant one here). I'd rather just return the whole finality_update as opposed to just the stateRoot.

ogenev commented 3 months ago

Did we ever decide whether we were going to add full-featured endpoints for beacon network stuff? I know @kdeme mentioned supporting a subset of the actual beacon endpoints specific to what we could return from Portal (e.g. /eth/v1/beacon/light_client/finality_update being the most relevant one here). I'd rather just return the whole finality_update as opposed to just the stateRoot.

Yeah, I was also thinking about this. We need to decide on the public-facing endpoints, probably returning full optimistic and finality updates makes sense for users and hive testing.

For Trin's internals, we will use endpoints that return only the roots, but this is of course client specifics and any client is free to implement whatever endpoints they want as long as the "official" endpoints are implemented too.