ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

Add `ContentNotFoundError` #343

Closed acolytec3 closed 1 month ago

acolytec3 commented 1 month ago

In the process of researching Ultralight test failures for Hive, I discovered that the JSON RPC spec currently advises that the portal_*localContent methods return 0x when no content is found. However, this did not solve a hive test failure for portal_beaconLocalContent for Ultralight when I updated our code to match this spec. After further research, I discovered that trin and fluffy return an error and not 0x when content is not found. This PR updates the spec to reflect the current implemented state of the clients.

Specifically:

acolytec3 commented 1 month ago

@ogenev @kdeme @KolbyML any outstanding thoughts or are you good with merging this?