search

ethereum / portal-network-specs

Official repository for specifications for the Portal Network
313 stars 85 forks source link

Add poke to state network spec #347

Open bhartnett opened 1 month ago

bhartnett commented 1 month ago

Poke in the state network is feasible by passing in the parent offer when looking up content. The fetched state content is then combined with the parent offer to build the offer which is used in the poke.

I'm not aware of any reason why poke should still be disabled in the state network, so I suggest we re-enable it.

bhartnett commented 1 month ago

This PR explains well how/when POKE can be executed in the Portal state network.

But it does not state that it MUST, SHOULD or MAY be executed (and/or in which occasion). This keeps it quite ambiguous on whether a client should/must implement this or not.

So I think as a bare minimum something should be added like: "POKE mechanism SHOULD be executed when the proof is available on the node/application.

(Intuitively I'm also a little bit on the fence regarding how "application space" gets directly involved here in maintaining the health of the network. But this hesitation is probably too unfounded and it should help for the health of the network.)

Good point. In my opinion, clients SHOULD implement poke because it should be encouraged in order to spread data across the network. I've updated with additional text as suggested.

bhartnett commented 4 hours ago

@kdeme @KolbyML @morph-dev Did you have any thoughts on this one?

I have already implemented poke in the state network in Fluffy (ready in a PR) so I'm keen to have this be part of the protocol for state network. I'm not aware of any reason not to implement it.