feat: add mcopy implementation

charles-cooper commented 9 months ago

What was wrong?

Re: EIP-5656, use memoryview slice/assign. note that this has the correct performance characteristics; see that cpython uses memmove here: https://github.com/python/cpython/blob/d2f1b0eb4956b4923f111c7c740ba7ab25f3312d/Objects/memoryobject.c#L357

pacrob commented 9 months ago

Thanks for getting this going! I've switched it to base off the existing cancun-network-upgrade branch, fixing the conflicts now.

fselmo commented 8 months ago

@charles-cooper @pacrob want to make another pass for more eyes on the changes when you have some time? I got all the tests passing. Took me way too long to realize some of those state tests don't take EIP-4788 into account 😔.

edit: I fixed up the issues with beacon roots address. Pushed a change to cancun-network-upgrade branch and rebased. Patching around it is no longer necessary since we only update the beacon roots if the address exists now. This should be good to go but would be nice to get eyes and a 👍🏼 before merging.

charles-cooper commented 8 months ago

looks good, we can combine the two calls to extend_memory() into one

ethereum / py-evm

feat: add mcopy implementation #2141

What was wrong?