ethereum / py-geth

Python wrapping for running Go-Ethereum as a subprocess
MIT License
100 stars 218 forks source link

Type geth kwargs with typed dict #213

Closed pacrob closed 5 months ago

pacrob commented 5 months ago

What was wrong?

As done with GenesisData in #210, type geth_kwargs using a TypedDict.

This does break some function signatures in the accounts.py file:

They now only take **geth_kwargs as their argument, so any positional args must now be passed as kwargs.

Upon reviewing python subprocess docs, we should only be passing strings, no ints. Updated geth_kwargs fields that were int type to all be str type.

Todo:

Cute Animal Picture

image