Make typing-extensions optional

ethereum / py-trie

Python library which implements the Ethereum Trie structure.

MIT License

105 stars 52 forks source link

Make typing-extensions optional #127

Closed Uxio0 closed 2 years ago

Uxio0 commented 2 years ago

It's not required for Python >= 3.8

sunwrobert commented 2 years ago

hi @kclowes , can we please merge this in? Currently running into issues when using eth-brownie and installing gnosis-py due to the typing-extensions dependency.

kclowes commented 2 years ago

Thanks for the PR @Uxio0! I changed it to follow the compat pattern from web3, just to be consistent across our libraries. I also added additional lint runs for each Python version we support which feels a little overkill, but I've also run into issues with linting on different Python versions recently. I don't think it adds too much overhead but we can re-evaluate if it feels too clunky or if we want our tests to run faster later.

kclowes commented 2 years ago

@Uxio0 @sunwrobert I'll get this released early next week!

kclowes commented 2 years ago

Sorry about the delay, @Uxio0 and @sunwrobert. 2.0.1 is out with this change!